-
Notifications
You must be signed in to change notification settings - Fork 50
support client-common 2.0 #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
26e3f7c
to
29737ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
I dont think so.. I rather make the number of libraries to bump as small as possible". Of course we should bump it if there are any strong reason for it |
29737ee
to
ffd219f
Compare
@Nyholm could you please also review php-http/client-common#123 ? |
b37e0bb
to
397659a
Compare
397659a
to
e9e1bd3
Compare
build failure is the same as for master. some problem with phpunit component versions afaik. |
and we should not need a new major version for this, there are no code changes needed. |
Thank you |
Current PR brings up an issue... If you keep supporting both versions of HTTP-Client you can not depend on the PSR. Is this the direction you want this to go? |
True. But we are not depending on the psr. Are we? |
OK.. I should started this conversation here.. let's continue on the PR of yours here #295 |
What's in this PR?
Handle version 2 of client-commons with a check for the Impl classes.
Why?
Those classes where moved to make room for the interface.
Checklist
To Do
Should we bump the version of the bundle as well? There are some BC breaks and people might rely on the bundle to bring in the whole httplug libraries...